Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proof_of_sql_parser::intermediate_ast::BinaryOp with sqlparser::ast::BinaryOp in the proof-of-sql crate #349

Closed
3 tasks
Tracked by #356
iajoiner opened this issue Nov 7, 2024 · 1 comment · Fixed by #362
Labels
refactor Code cleanup or reorganization released

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Nov 7, 2024

Background and Motivation

This issue is a subtask in #235. In short since we plan to add more SQL features we plan to switch to the sqlparser crate which is a feature-rich, no_std-compatible parser used by DataFusion, which is part of the Arrow ecosystem.

Right now we already have some code that can convert intermediate AST from proof-of-sql-parser we use to sqlparser AST. Now we need to systematically replace instances of proof-of-sql-parser constructs with their corresponding sqlparser ones.

Changes Required

  • Replace proof_of_sql_parser::intermediate_ast::BinaryOp with sqlparser::ast::BinaryOp in the proof-of-sql crate.
  • Make sure no functionality is lost.
  • If necessary add error enum variants for unary ops in sqlparser that we don't support yet.
Copy link

🎉 This issue has been resolved in version 0.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code cleanup or reorganization released
Projects
None yet
1 participant