Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse string of scientific notation to decimal when the scale is 0 #2

Closed
wants to merge 2 commits into from
Closed

fix: parse string of scientific notation to decimal when the scale is 0 #2

wants to merge 2 commits into from

Conversation

yjshen
Copy link

@yjshen yjshen commented May 10, 2024

Unable to parse scientific notation string when the scale is 0.

parse_decimal::<Decimal128Type>("1.234e16", 20, 0).unwrap()
called `Result::unwrap()` on an `Err` value: ParseError("can't parse the string value 1.234e16 to decimal")

What changes are included in this PR?

Bug fix and also tests.

Are there any user-facing changes?

No.

@yjshen yjshen requested a review from sachin-snt May 10, 2024 02:29
@github-actions github-actions bot added the arrow label May 10, 2024
@yjshen
Copy link
Author

yjshen commented May 24, 2024

Closing this since it has been merged upstream

@yjshen yjshen closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-snt sachin-snt sachin-snt approved these changes

Assignees
No one assigned
Labels
arrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjshen @sachin-snt