-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forking guidelines #324
base: master
Are you sure you want to change the base?
Conversation
This looks great so far! But it's missing a section on licensing and attribution. We should at the very least give people a basic idea of what copyright is/does, since not everyone is familiar with it and there are a ton of common misconceptions that can get you into trouble. Actually, I might just make a separate doc on copyright/licensing and then just include a brief summary in the forking guidelines. Great work on this :) |
- If you do not want an upstream feature, now is the time to revert the change using `git revert` | ||
|
||
Note that any contributors to your fork will need to press the github fork button on your repository instead of your upstream's. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a short section here summarizing the basics of copyright/licensing to help prevent people from falling into common pitfalls. I'll write something up this week unless you'd like to write something up and I can look it over :)
Once we've got that, this will be good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually had some something small about the AGPL (most forks are not using it correctly, they are incorrectly relicensing wizden code to the AGPL when merging upstream), but opted not to include it because I did not want to start shit due to how much of a hot topic that is in ss14. We could link https://choosealicense.com/ which is written by github and I assume vetted by their lawers. I think that this document should take as much of a neutral perspective in terms of which license to choose because that is a highly personal choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of the main issues with the above site is it encourages using the GPL over the AGPL for a copyleft license which is sound advice for most projects, but will probably not do what they intend for a ss14 fork.
I actually ended up writing a short copyright gide. Let me know if you want me to change anything. My goal was to take as neutral of a stance as possible while giving a basic explanation of all of the licenses that I am aware of ss14 forks using. If people don't understand the basics of software copyright I think they should be referred elsewhere given it is such a complex topic and most (all?) of the people who work on ss14 are not experts in it and such should not be writing a guide on copyright. |
Adds a page outlining forking guidelines and best practices. A large amount of content in this is derived from https://gist.github.com/moonheart08/2d3945faf3cf691437e1e1fa0e922420. I have permission from the author to use their work in this PR. It also incorporates some of my own advice gained from working on Cosmatic Drift.