Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shaders] Custom sky rendering issue when using shaders #7784

Open
CeelB-2055440 opened this issue Oct 28, 2024 · 9 comments
Open

[Shaders] Custom sky rendering issue when using shaders #7784

CeelB-2055440 opened this issue Oct 28, 2024 · 9 comments

Comments

@CeelB-2055440
Copy link

Description of Issue

When I use optifine with a resource pack that makes use of customs skies (lets say JohnSmithLegacy), then the rendering goes wrong when optifine internal shaders are enabled.

Steps to Reproduce

Enable internal shaders
Enable custom sky
Enable a resourcepack that makes use of it.

OptiFine Version

OptiFine HD U J2 pre1 (1.21.3)

Installation Method

Included standalone installer

Fabric/Forge Version

N/A

OptiFabric Version

N/A

Other Installed Mods

N/A

Log Files/Crash Reports

latest.log

F3 Debug Screenshot

image

Prior Testing

In vanilla there is no problem.
When shaders are disabled, there is no problem.
When custom sky is disabled there is no problem.

Additional Information

Schermafbeelding 2024-10-28 192401
(You can ignore the time set 18000 (OF is set to day only))

@CeelB-2055440
Copy link
Author

Problem continues to exist in version: OptiFine HD U J2 pre2 (1.21.3)

@CeelB-2055440
Copy link
Author

Problem continues to exist in version: OptiFine HD U J2 pre3 (1.21.3)

@CeelB-2055440
Copy link
Author

I have found that it doesn't work with any shader pack.

@schrodingerspsycho
Copy link

Problem continues to exist in version: OptiFine 1.21.3_HD_U_J2_pre4 (1.21.3)

@schrodingerspsycho
Copy link

Problem continues to exist in version: OptiFine 1.21.3_HD_U_J2_pre5 (1.21.3)

@ZenithRogue
Copy link
Collaborator

"Internal Shaders" are not actually supposed to be used. They are just there for debugging purposes

@sp614x
Copy link
Owner

sp614x commented Nov 15, 2024

Renamed internal shaders to debug shaders.

@schrodingerspsycho
Copy link

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre6
As it was stated, the problem affects all shaders, not just debug/internal ones, for example I use Sildur's Enhanced Default v1.171 Fancy, they do break in OF for 1.21.3 and do work fine with 1.21.1-OptiFine_HD_U_J1

@ZenithRogue ZenithRogue changed the title [Category] Custom sky incompatible with internal shaders [Shaders] Custom sky rendering issue when using shaders Nov 18, 2024
@schrodingerspsycho
Copy link

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre7
+some buggy skybox culling has appeared:
2024-11-23_00 06 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants