Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent renaming "Contract Definition" to "Data Offer" #831

Closed
tmberthold opened this issue Sep 17, 2024 · 1 comment · Fixed by #840 or #862
Closed

Inconsistent renaming "Contract Definition" to "Data Offer" #831

tmberthold opened this issue Sep 17, 2024 · 1 comment · Fixed by #840 or #862
Assignees
@illfixit
Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Milestone
MDS 2.2

Comments

@tmberthold
Copy link

Description - What happened? *

- Issue 1 : EDC UI dashboard page we have name mismatch Data offer and contract definitions
- Issue 2 : Incorrect error message displayed "No contract definition found with given filter" when search data offer is not available
- Issue 3 : When we publish new data offer(contract definitions) incorrect error message is displayed

Expected Behavior *

Renaming "Contract Definition" to "Data Offer" in all places

Observed Behavior *

Inconsistent renaming "Contract Definition" to "Data Offer", see Screenshots for exmaples.

Steps to Reproduce

No response

Context Information

No response

Relevant log output

No response

Screenshots

image

image

image
@tmberthold tmberthold added kind/bug Something isn't working. The software does not behave as expected or specified. bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. scope/mds related to MDS labels Sep 17, 2024
@tmberthold tmberthold added this to the MDS 2.2 milestone Sep 17, 2024
@illfixit illfixit self-assigned this Sep 20, 2024
@illfixit illfixit mentioned this issue Sep 20, 2024
Merged
@illfixit illfixit linked a pull request Sep 20, 2024 that will close this issue
feat: complete renaming of contract definition into data offer #840
Merged
@jkbquabeck jkbquabeck reopened this Sep 27, 2024
@jkbquabeck
Copy link
Collaborator

https://github.com/Mobility-Data-Space/MDS-Project/issues/224#issuecomment-2378975635
Dashboard still needs to be aligned in wording. @illfixit

This was referenced Sep 29, 2024
Merged
Merged
@illfixit illfixit linked a pull request Oct 2, 2024 that will close this issue
fix: data offer renaming #862
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illfixit illfixit

Labels
bug/usability Bug makes the software difficult to use. Likely related to UI, documentation. kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Projects
None yet
Milestone
MDS 2.2
3 participants
@illfixit @tmberthold @jkbquabeck