Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer History is updated when asset is modified #978

Open
drmVR opened this issue Jun 18, 2024 · 3 comments
Open

Transfer History is updated when asset is modified #978

drmVR opened this issue Jun 18, 2024 · 3 comments
Labels
kind/bug Something isn't working. The software does not behave as expected or specified.

Comments

@drmVR
Copy link

drmVR commented Jun 18, 2024

Description - What happened? *

When editing an asset, the Transfer History in the Connector UI is also updated, eventhough the asset description was a different one when the contract was negotiated.

Expected Behavior *

The Transfer History should persist the asset at the time of the contract negotiation.

Observed Behavior *

The Transfer History is updated and displays the modified version of the asset.

Steps to Reproduce

  • Create an Asset, Policy and Contract Definition.
  • Consume this data offer with a second connector.
  • Edit the Asset.
  • Navigate to "Transfer History" and open "Asset".
  • The modified description will be displayed.

Context Information

No response

Relevant log output

No response

Screenshots

No response

@drmVR drmVR added the kind/bug Something isn't working. The software does not behave as expected or specified. label Jun 18, 2024
@tmberthold
Copy link
Contributor

Hi @drmVR,
Thank you for opening this issue! 🚀
We appreciate your feedback and will review it as soon as possible.
Your issue has been forwarded to our internal team for further investigation (@jkbquabeck).

@ip312
Copy link

ip312 commented Jun 18, 2024

The situation is even more complex. Not only Transfer History, but also Contract History is updated as soon as the asset was edited.
For the Contract History the requirement is pretty clear: the asset description at the time of the contract negotiation should be persisted.
For the Transfer History different solutions are applicable.
The best one: the asset description at the time of transaction is persisted.
The second best one: the asset description at the time of contract negotiation is persisted.
The third best one: the current solution.

@ip312
Copy link

ip312 commented Jun 18, 2024

Therefore the logging of asset changes is absolutely crucial, not nesessarily "the complete change history and versions" as stated in the linked issue, but at least a timestamp of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working. The software does not behave as expected or specified.
Projects
None yet
Development

No branches or pull requests

3 participants