Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice to be able to pass options to elasticsearch_service #334

Closed
jro opened this issue Jul 7, 2015 · 4 comments
Closed

It would be nice to be able to pass options to elasticsearch_service #334

jro opened this issue Jul 7, 2015 · 4 comments
Milestone

Comments

@jro
Copy link

jro commented Jul 7, 2015

Eg, In cases we don't wish to have the service enabled but do want the cookbook generated init scripts or when we want to use chef to manage starting/stopping the service.

https://github.com/elastic/cookbook-elasticsearch/blob/master/libraries/provider_service.rb#L64-L67

@martinb3
Copy link
Contributor

martinb3 commented Jul 7, 2015

Hi there -- so are you mostly looking for toggle flags for enable/disable and start/stop actions on the service? Or are you thinking of other specific options? Cheers.

@jro
Copy link
Author

jro commented Jul 7, 2015

Those toggle flags would solve my issues. I could certainly see the case for providing options around the system limit modifications, but they're fine for my use case.

@martinb3 martinb3 modified the milestone: 1.1.x release Jul 16, 2015
@martinb3
Copy link
Contributor

I merged #357 in earlier today which should allow you to override the init scripts and specify your own actions when configuring the service (e.g. you could now pass :nothing if you don't want the service enabled, or :start if you want it started, etc). Are there other things that you would like to have as options?

@martinb3
Copy link
Contributor

Options have been added to specify a different init script template, as well as a different set of initial actions to perform:

    # service actions
    attribute(:service_actions, kind_of: [Symbol, Array], default: [ :enable ])

    # allow overridable init script
    attribute(:init_source, kind_of: String, default: 'elasticsearch.init.erb')
    attribute(:init_cookbook, kind_of: String, default: 'elasticsearch')

Please open an issue with additional specific options you are looking for with the service resource. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants