Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include build-essential just to be sure apt is up to date #241

Closed
martinb3 opened this issue Oct 3, 2014 · 0 comments
Closed

Don't include build-essential just to be sure apt is up to date #241

martinb3 opened this issue Oct 3, 2014 · 0 comments

Comments

@martinb3
Copy link
Contributor

martinb3 commented Oct 3, 2014

First, build-essential is a big dependency just to avoid ensuring apt and yum are up to date. The apt and yum cookbooks have ways to do that which don't also involve installing autoconf and GCC. I'd argue this is the wrong dependency to include if the goal is to ensure package metadata is up to date. See #88 for how this came to be.

Secondly, build-essential and forcing it run at compile time takes control away from the developer/user; most folks are already following the pattern of ensuring apt or yum is up to date before calling dependent cookbooks, and if we move build-essential to compile time, it actually can create a race condition between what people's wrappers are doing and the elasticsearch cookbook is doing -- we could be moving build-essential in front of gathering apt/yum metadata. That's what happened to me in this report, so now I have autoconf failing to install because build-essential was moved before it due the change above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant