Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument order to pull when tag specified. #67

Merged
merged 1 commit into from
Feb 11, 2014

Conversation

jcrobak
Copy link

@jcrobak jcrobak commented Feb 11, 2014

Fixes an error with pulling a container at a tag (docker requires all flag args before positional args). e.g. with the current impl you'll see:

Expected process to exit with [0], but received '2'       
---- Begin output of docker pull registry  -t 0.6.5 ----       
       STDOUT: 

       STDERR: Usage: docker pull NAME

       Pull an image or a repository from the registry

         -t="": Download tagged image in repository
       ---- End output of docker pull registry  -t 0.6.5 ----
       Ran docker pull registry  -t 0.6.5 returned 2

@bflad
Copy link
Contributor

bflad commented Feb 11, 2014

I should probably go through all of them and verify the correct ordering. Thanks!

bflad added a commit that referenced this pull request Feb 11, 2014
Fix argument order to pull when tag specified.
@bflad bflad merged commit e0a1ec7 into sous-chefs:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants