Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login command skipped in registry provider #65

Closed
jschneiderhan opened this issue Feb 10, 2014 · 0 comments
Closed

login command skipped in registry provider #65

jschneiderhan opened this issue Feb 10, 2014 · 0 comments

Comments

@jschneiderhan
Copy link
Contributor

I may be wrong here, but I think https://github.com/bflad/chef-docker/blob/master/providers/registry.rb#L29 is always returning true, causing the docker login command to always be skipped. Would checking new_resource.update_by_last_action? have the desired effect? I'm guessing the point of the check is to make sure the login command is only called once for a particular server. I'll try it out and post a PR if it works.

@bflad bflad closed this as completed in 166e24e Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant