Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'run' argument to docker_container :commit #44

Closed
ghost opened this issue Jan 7, 2014 · 3 comments
Closed

Include 'run' argument to docker_container :commit #44

ghost opened this issue Jan 7, 2014 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 7, 2014

It would be very useful to be able to specify the run command when committing a container, like in the case where some one needs to interact with Docker outside of Chef and may have no access to the run command specified in the recipe.

@bflad
Copy link
Contributor

bflad commented Jan 7, 2014

Great idea. I was thinking of adding this from the get go, obviously I should've just done it. I'm thinking maybe runspec as the name for the attribute? Have you tried using the new actions? Do they work in your environment? I was implementing features ahead of my usage/testing.

@ghost
Copy link
Author

ghost commented Jan 7, 2014

I would suggest that you simply name it 'run' to simplify 'translation' between the docker CLI and cookbooks, though I guess that may be a moot point since other attributes already differ some what. Just my opinion. :)

I was happy to find the new support for importing from tarballs, though I may have stumbled across a bug that I'll have to investigate more tomorrow (attempting to import two in a row resulted in one or both succeeding depending on the ordering, so I don't know if it's just on my end yet).

@bflad bflad closed this as completed in 734419f Jan 10, 2014
@bflad
Copy link
Contributor

bflad commented Jan 10, 2014

Released in 0.25.1. Enjoy! If you had time to investigate the possible bug, please submit a new issue and I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant