Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upstart): Install inotify-tools if using upstart #42

Merged
merged 1 commit into from
Jan 2, 2014

Conversation

jayofdoom
Copy link
Contributor

My primary concern is that it appears inotify-tools is only available in RHEL via EPEL? Given they don't use upstart though, is this an issue? I don't really run any redhat-based OSes so it's a bit hard for me to tell.

@bflad
Copy link
Contributor

bflad commented Jan 2, 2014

Great catch. Surprised I haven't run into this during testing. Anything special about your Ubuntu setup? :)

While you could theoretically use Upstart init_type on RHEL family machines, I don't think we need to necessarily support it since CentOS/RHEL 6 is primarily sysv (by default) and 7 will be primarily systemd (by default assuming they're following Fedora's footsteps - I haven't messed around with the 7 Beta yet). I guess we'll see if anyone really wants it; it wouldn't be too hard to add.

bflad added a commit that referenced this pull request Jan 2, 2014
fix(upstart): Install inotify-tools if using upstart
@bflad bflad merged commit bd64a8f into sous-chefs:master Jan 2, 2014
@jayofdoom
Copy link
Contributor Author

@bflad While I have this running on real machines, most of the issues I'm filing is against a local vagrant VM based on Ubuntu Precise w/the Saucy kernel installed. Basically all it's doing is installing omnibus chef, and running a small recipe that loads all these. I intend on using chef-docker to manage all this in production as well, hence why I've been finding+fixing every little thing I see in dev to lessen impact when I take this to my production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants