Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoMethodError bugs in docker::aufs recipe #39

Merged
merged 1 commit into from
Jan 2, 2014

Conversation

trinitronx
Copy link
Contributor

Fixing some bugs introduced in #35:

NoMethodError
-------------
undefined method `empty?' for nil:NilClass '`

NoMethodError
-------------
undefined method `Version' for Gem:Module`

Tests passing via:

  1. bundle exec kitchen test ubuntu
  2. bundle exec foodcritic .
  3. bundle exec rubocop
  4. bundle exec knife cookbook test

Note: fedora-19 currently has a problem running the docker tests, but
this was already happening before #35. Please see this gist

@bflad
Copy link
Contributor

bflad commented Jan 2, 2014

Thanks for the fixes, this will be released in 0.23.1 (just pushed 0.23.0).

bflad added a commit that referenced this pull request Jan 2, 2014
Fix NoMethodError bugs in docker::aufs recipe
@bflad bflad merged commit 6117144 into sous-chefs:master Jan 2, 2014
@trinitronx trinitronx deleted the fix-NoMethodError-bugs branch January 2, 2014 16:48
@jayofdoom
Copy link
Contributor

Sorry about this; I thought .empty? just returned False in a nil situation.

@trinitronx
Copy link
Contributor Author

@jayofdoom yeah no problem, I've made the same mistake before ;-)

👍 on the handling of the aufs package edge case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants