Fix accidental port changing when using systemd templates. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use `port.gsub!` - you are changing the value port variable itself, and as long as the value is not local to this method, but is a part of new_resource record (when it's passed as an array or string) - the previous code will modify `new_resource.port` instance variable.
|
+1 |
tduffield
pushed a commit
that referenced
this pull request
Jan 30, 2015
Fix accidental port changing when using systemd templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use
port.gsub!- you are changing the value port variableitself, and as long as the value is not local to this method, but
is a part of new_resource record (when it's passed as an array or
string) - the previous code will modify
new_resource.portinstancevariable.