Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lengthen shell_out timeout as workaround for slow docker_container action stop. #246

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

jperville
Copy link
Contributor

On at least 2 of my servers the docker stop command runs unusually slow. As the benchmark below shows, stopping a container seems to take around 20s more than the graceful stop delay. In this PR, I workaround the issue by increasing the shell_out timeout from its current 15 (already a workaround) to 30 seconds.

root@staging2-ng:~# time docker stop --time=1 125b758d437f
125b758d437f

real    0m22.546s
user    0m0.010s
sys 0m0.007s
root@staging2-ng:~# time docker stop --time=1 fd00d6158eaa
fd00d6158eaa

real    0m22.698s
user    0m0.007s
sys 0m0.010s
root@prod1-ng:~# time docker stop --time=1 1 509ca18cf34e
509ca18cf34e

real    0m23.603s
user    0m0.009s
sys 0m0.007s

Have to investigate the issue more and see if I should open a bug report on docker github, but since the problem shows on multiple servers I submit this PR as workaround.

@djdefi
Copy link

djdefi commented Dec 3, 2014

I run into this occasionally with some of our containers. Does not seem to be consistent though, sometimes they will stop quickly, other times they hit the timeout.

tduffield pushed a commit that referenced this pull request Jan 30, 2015
Lengthen shell_out timeout as workaround for slow docker_container action stop.
@tduffield tduffield merged commit 44d97a0 into sous-chefs:master Jan 30, 2015
@jperville jperville deleted the docker-stop-timeout branch September 21, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants