Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node['docker']['no_proxy'] to complement the existing http_proxy attribute. #221

Closed
wants to merge 2 commits into from

Conversation

jperville
Copy link
Contributor

Even if little advertised, the docker daemon respects the NO_PROXY environment variable if present.

Setting this variable can be desirable to avoid passing through a proxy, for example when accessing a local docker registry (even more when the docker registry is running on an host that is not reachable from the http proxy such as localhost).

This PR adds a new attribute, node['docker']['no_proxy'] which will be injected in the default docker configuration, exactly like for the node['docker']['http_proxy'] attribute.

@jperville jperville changed the title Added node['docker']['no_proxy'] to the existing http_proxy attribute. Added node['docker']['no_proxy'] to complement the existing http_proxy attribute. Oct 29, 2014
@tduffield
Copy link
Contributor

I like it. We'll slate it for the next minor release.

@jperville
Copy link
Contributor Author

Thank you @tduffield

@boldfield
Copy link

Fixes #227

Just wanted to link this PR to an open issue so you don't get any more PRs trying to add this feature.

@tduffield
Copy link
Contributor

Merged into 0.36-stable. Will be released in 0.36.0.

@tduffield tduffield closed this Nov 7, 2014
@jperville jperville deleted the docker-no-proxy branch September 21, 2015 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants