Added node['docker']['no_proxy'] to complement the existing http_proxy attribute. #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if little advertised, the docker daemon respects the
NO_PROXY
environment variable if present.Setting this variable can be desirable to avoid passing through a proxy, for example when accessing a local docker registry (even more when the docker registry is running on an host that is not reachable from the http proxy such as localhost).
This PR adds a new attribute,
node['docker']['no_proxy']
which will be injected in the default docker configuration, exactly like for thenode['docker']['http_proxy']
attribute.