Fixed current_resource.name assignment in providers. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
tduffield
pushed a commit
that referenced
this pull request
Oct 24, 2014
…roviders Use new_resource.name as parameter value instead of new_resource in providers.
|
Thank you very much for the merge @tduffield |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating another issue, I found out that the load_current_resource methods all providers initialize the current_resource with the new_resource instance. This is incorrect (even if this does not stop the resources from converging) but it makes inspecting the current_resource more difficult to read (the name attribute will be an object instead of the expected string).
In the example given in the official documentation the current_resource is instantiated using the new_resource name attribute, which is exactly what this PR does.