Fix how service actions are invoked. #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would be great if this fixes the issue, because we're having random failures during deployment (failed to stop container, remove image, etc)! Trying to get @bflad 's attention 👍 |
|
+1 would love a new release with this and some of the other merge requests. |
tduffield
pushed a commit
that referenced
this pull request
Oct 24, 2014
Fix how service actions are invoked.
tduffield
pushed a commit
that referenced
this pull request
Nov 6, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #194 and #198 I think.
This pull request is some initial thoughts on how to prevent docker service definitions from squashing over each others actions. Here, the service should (most likely) only be defined once and from there have it's action invoked immediately. Using this immediately fixed issues I had with redeploy.
Another possible solutions could be using
docker rminstead ofservice_action(:stop)indef stop.This may or may not be the best way to solve this problem but I at least wanted to throw this up to get some feedback.