adding split on commas in container_name_matches? definition

[bplunkert]

This should fix issue #184

[bplunkert]

To add a bit more detail: when a container links another container, the latter container's names will be updated to reflect the link.

i.e. containerA links containerB:xyz
names of containerB go from: "containerB" to "containerB,containerA/xyz"

Since comma is not an allowable character in a container name, it should be safe to split names by ',' and handle the first sub-string as the name of the container.

[bplunkert]

I'm working on some tests for this (in test/cookbooks/docker_test/recipes/container_lwrp.rb and test/cookbooks/docker_test/files/default/tests/minitest/container_lwrp_test.rb) but running on so many suites takes a very long time, and it seems like there may be some pre-failing tests lurking about. If anyone can offer any time-saving pointers, that'd be helpful -- otherwise I'll keep trying and start filing issues for any failing tests I find along the way.

[bplunkert]

I'm going to hold off on committing tests for this until tests are generally passing so as to avoid polluting them further. In the meantime, though, this fix is essential if you are linking containers and need to run chef more than once, so it may be worthwhile to merge it anyway?

[jf647]

On my system, the original container name isn't necessarily the first element of the CSV list of names:

b8425ae8eca9        cepl-postgresql:9.1   /bin/sh -c '/usr/bin   8 days ago          Up 8 days           0.0.0.0:5432->5432/tcp                             jira/db,postgresql,stash/db

That container was started with "--name postgresql", then later on I started two more named "stash" and "jira", both linked to "postgresql" as "db".

So the comparison would better be written as:

named.split(',').include?(new_resource.container_name)

Cheers

[bplunkert]

@jf647 thanks! I hadn't considered that possibility, but your solution should definitely be more resilient. I've added a commit which implements the include? method.

[bflad]

This is an important fix. Thanks!