Better support for named containers #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies container matching to look only at the container name for cases in which a
:container_name
is explicitly provided. The spec I added demonstrates the use case I'm trying to support: namely, deploying newer versions of a tagged image when they become available. Right now, if I pull an updated version of thebusybox
image, I can't redeploy an existingbusybox-container
with the latest image, because the image ID doesn't match.In particular, I get the following error:
Does this change jibe with your idea of how container resources should be used?
The kitchen tests passed locally, with the one exception of the
apt-get
failure addressed in #155.