Fix hosts file entry #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramereth
requested changes
Aug 26, 2021
ramereth
added
the
Release: Minor
|
Thank you for taking the time to review my MR. Dependency and changelog updated as per recommendations. |
Co-authored-by: Lance Albertson <[email protected]>
ramereth
force-pushed
the
fix_hosts_file_entry
branch
from
937ae44 to
f2b9572
Compare
Generated by 🚫 Danger |
damacus
reviewed
Sep 9, 2021
Fix for delivery
|
Looks like this one is a bit of a rabbit hole.we should fix the hostile cookbook first |
|
Yeah that was my initial thought. However, it hasn't had a MR approved/merged since 2017 (https://github.com/customink-webops/hostsfile). It may need to be adopted. |
|
Ah, actually we can remove the dependency completely probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves
Issues Resolved
#74
Check List