Use GPG for rvm verification. #285
Conversation
rvm will fail to install if GPG is present on the system, but the key for rvm is not found. This behaviour will be skipped if the `gpg_key` node is an empty string. Fixes sous-chefs#278
|
and 👍 |
Apparently some servers may have the former instead of the latter.
|
@fnichol let me know if you'd like these commits squashed before merging. |
| @@ -30,4 +30,10 @@ | |||
| g.run_action(:create) | |||
| end | |||
|
|
|||
| execute 'Adding gpg key' do | |||
| command "gpg --keyserver hkp://keys.gnupg.net --recv-keys #{node['rvm']['gpg_key']}" | |||
| only_if 'which gpg || which gpg2' | |||
There was a problem hiding this comment.
with this check you need to change the command to something like:
"`which gpg || which gpg2` --keyserver hkp://keys.gnupg.net --recv-keys #{node['rvm']['gpg_key']}"There was a problem hiding this comment.
also in RVM the check order is reversed to which gpg2 || which gpg - although they are supposed to be compatible the v2 might be safer one day
There was a problem hiding this comment.
Ah right, duh, thanks.
Defaulting to gpg2, for parity with rvm.
|
@martinisoft this looks good - can you review? |
|
Looks good enough to me. Currently the test suites have been proven to be broken all along and the re-factor to LWRPs is still pending. Will be giving it some attention this weekend and next week so this seems like a great idea to roll in to master for now. Can't hurt 👍 |
Use GPG for rvm verification.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
rvm will fail to install if GPG is present on the system, but the key for rvm is not found.
This behaviour will be skipped if the
gpg_keynode is an empty string.Fixes #278
Based on this fix, IndependentIP@56f2459, by @marijnm.