-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several sets of changes #26
Conversation
…e, so that rvm::gem_package is compatible with cookbooks that run gem_package during compile phase.
…sion w/ expected GIDs in other cookbooks)
These are great adds and fixes, thanks! There's only one thing I had a question about. I was looking at pushing the rvm gem install into the execute phase to be more in line with the other opscode cookbooks. It looks like most are being updated to clear out these kinds of problems (chef-boneyard/cookbooks@9597eb7). But you're right that if there are cookbooks running |
I can see legitimate need for other cookbooks to put gem_package calls in the compile phase, but MySQL's the only cookbook that we encountered this problem with so far. |
Pulled in and updated a couple of things. Mainly:
Thanks again for your help, I think we have a more robust |
My pleasure. Some more bug-fixes on this coming shortly. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
First commit fixes a bug with rvm::system and mysql::client (which runs gem_package at compile time).
Second commit is a workaround for an internal bug resulting in GID collision between recipes. It's less likely to be generally useful, but probably still worth including.
Third commit fixes an (intermittent?) bug found in first commit.
Fourth commit uses gem_package's native code if ruby_string == 'system', which will be a bit more useful once rvm::gem_package can use multiple environments.