Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error reporting on signature loading clearer #608

Closed
ctb opened this issue Jan 8, 2019 · 2 comments
Closed

make error reporting on signature loading clearer #608

ctb opened this issue Jan 8, 2019 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Jan 8, 2019

For now, load_signatures will by default print out an error message when it cannot load a signature from a file, but will not raise an exception. The error message isn't particularly clear - at the least we should make sure to report what file is causing the problem.

A complementary and perhaps better idea is to write a new function for loading signatures from multiple files and directories that does better reporting

@ctb
Copy link
Contributor Author

ctb commented Jan 8, 2019

(see the machinations needed in the implementation of sourmash sig describe to accurately report errors for an example of this :)

@ctb
Copy link
Contributor Author

ctb commented Jul 3, 2020

hey, cool, this was fixed in #1059

@ctb ctb closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant