Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sourmash load_signatures FASTA-aware #460

Closed
ctb opened this issue Mar 22, 2018 · 3 comments · Fixed by #1078
Closed

make sourmash load_signatures FASTA-aware #460

ctb opened this issue Mar 22, 2018 · 3 comments · Fixed by #1078

Comments

@ctb
Copy link
Contributor

ctb commented Mar 22, 2018

I pretty frequently try to query or search FASTA files by mistake, and I get a JSON parsing error. it'd be nice to have it say "this is a FASTA file, run sourmash compute you dolt!"
@ctb
Copy link
Contributor Author

ctb commented Dec 26, 2018

might be good to do along with #219

@ctb
Copy link
Contributor Author

ctb commented Jun 20, 2020

kinda relevant to #814

@ctb
Copy link
Contributor Author

ctb commented Jul 3, 2020

I think this can go in the new _load_databases code introduced in #1059. That's used by almost all of our CLI-based signature loading functions now, so we can kill this off in one fell swoop!

@ctb ctb mentioned this issue Jul 3, 2020
Merged
5 tasks
@ctb ctb closed this as completed in #1078 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] autodetect FASTA/FASTQ files if given as signatures sourmash-bio/sourmash
1 participant
@ctb