Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regularized 'scaled' type in Rust code #3363

Open
ctb opened this issue Oct 26, 2024 · 0 comments · May be fixed by #3364
Open

regularized 'scaled' type in Rust code #3363

ctb opened this issue Oct 26, 2024 · 0 comments · May be fixed by #3364
Labels
rust

Comments

@ctb
Copy link
Contributor

ctb commented Oct 26, 2024

In Selection, scaled is u32.
in Record, scaled is u64.
In some places in the code scaled is converted to usize.

Can we maybe just make it usize?
@ctb ctb added the rust label Oct 26, 2024
@ctb ctb linked a pull request Oct 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: standardize on u64 for scaled, and others sourmash-bio/sourmash
1 participant
@ctb