write more comprehensive Index.select(...)
tests
#1427
Labels
good next issue
An issue that should be ready to resolve.
repeatable quest
Issues with many, many subtasks; good for people new to codebase.
testing
#1420 dramatically simplifies and exposes the logic around database compatibility, and makes it possible to test the API directly in Python rather than through the
sourmash
command line (which is how it's mostly tested right now).At a high level, this issue entails:
select
interface for keyIndex
subclasses:LinearIndex
,MultiIndex
,SBT
,LCA_Database
I suggest doing things in the following order:
test_index.py
that directly test each branching condition in theselect_signature
functionLinearIndex
andMultiIndex
SBT
and LCA_Database` objectsNote that while the
select_signature
,LinearIndex
, andMultiIndex
tests may seem highly redundant at the moment (because they all rely onselect_signature
😉 ), it's kind of nice to have separate tests for each of these since they are used in varying circumstances and there is no guarantee that the underlying implementation will remain as it is.The text was updated successfully, but these errors were encountered: