Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a sourmash classify command? #1099

Closed
ctb opened this issue Jul 13, 2020 · 4 comments
Closed

implement a sourmash classify command? #1099

ctb opened this issue Jul 13, 2020 · 4 comments
Labels

Comments

@ctb
Copy link
Contributor

ctb commented Jul 13, 2020

I've been pretty impressed with the performance of gather as revealed by @luizirber and @bluegenes, vs the challenges of getting LCA-based approaches to work nicely.

Maybe it's time to implement a 'classify' command that takes a gather database and a lineages spreadsheet and classifies to the desired rank?

I'm currently only +0 on this. The + and - are described pretty well here --

ref #969

a few random thoughts --

  • with sbts in zip files, this can be really lightweight
  • charcoal already does something similar, and it's only a few lines. could add it there as 'charcoal classify' instead.
  • not sure how to explain and/or configure the user experience around "do I use a protein database, or a DNA database?"

still +0, maybe verging on 0... it'd be nice to have as a built in command in some circumstances tho! like lca classify but better.

@bluegenes
Copy link
Contributor

bluegenes commented Jul 13, 2020

+1 from me, as I've been using some of your charcoal / other implementations to do this.

I was thinking it would be nice to optionally enable classification as output of multigather if a lineage file is provided.

@luizirber
Copy link
Member

(even better if it generates a CAMI profile =])

@ctb
Copy link
Contributor Author

ctb commented Jul 15, 2020

also ref #984

@ctb
Copy link
Contributor Author

ctb commented Jun 26, 2021

I think with #1543 we ended up going in a different, slightly more complicated, but also more flexible direction. Closing this for now.

@ctb ctb closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants