Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix sg ops update images and use as part of the release process #45751

Open
daxmc99 opened this issue Dec 15, 2022 · 2 comments
Open

Fix sg ops update images and use as part of the release process #45751

daxmc99 opened this issue Dec 15, 2022 · 2 comments
Labels
release-tool Sourcegraph release tool: https://github.com/sourcegraph/sourcegraph/tree/main/dev/release sg sg, the Sourcegraph developer command

Comments

@daxmc99
Copy link
Contributor

daxmc99 commented Dec 15, 2022

We currently use tools/update-docker-images.sh as part of the release.

https://github.com/sourcegraph/sourcegraph/blob/main/dev/release/src/release.ts#L572

https://sourcegraph.com/search?q=context%3Aglobal+repo%3A%5Egithub%5C.com%2Fsourcegraph%2F+file%3Aupdate-docker-tags.sh&patternType=standard&sm=1&groupBy=repo

We could replace these old scripts with sg ops update-images once we fix the formatting issues it has today.

sourcegraph/deploy-sourcegraph#4207

Problem:
We sometimes do not update images as part of the release (ie blobstore in the v4.2.1 release). So far, this hasn't been an issue, but it could become one eventually.

@daxmc99 daxmc99 added release-tool Sourcegraph release tool: https://github.com/sourcegraph/sourcegraph/tree/main/dev/release sg sg, the Sourcegraph developer command labels Dec 15, 2022
@bobheadxi
Copy link
Member

once we fix the formatting issues it has today.

The current approach parses k8s manifests, we will likely have to rewrite it with a regexp approach like https://github.com/sourcegraph/update-docker-tags to avoid this

@bobheadxi
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-tool Sourcegraph release tool: https://github.com/sourcegraph/sourcegraph/tree/main/dev/release sg sg, the Sourcegraph developer command
Projects
None yet
Development

No branches or pull requests

2 participants