Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hovers for Scala sources #279

Closed
olafurpg opened this issue Aug 3, 2021 · 2 comments
Closed

Add hovers for Scala sources #279

olafurpg opened this issue Aug 3, 2021 · 2 comments
Assignees
@olafurpg
Labels
dependency-indexing team/code-intelligence

Comments

@olafurpg
Copy link
Member

olafurpg commented Aug 3, 2021

Currently, hovers are not working for Scala sources because the generated SemanticDB document is missing SymbolInformation nodes. The symbol information is missing because the Metals mtags module explicitly disables symbols here
https://github.com/scalameta/metals/blob/75355b207cf89943408d0726797b8a37f3aa1278/mtags/src/main/scala-2/scala/meta/internal/pc/SemanticdbTextDocumentProvider.scala#L36

We should contribute a PR upstream to make this behavior configurable.
@olafurpg olafurpg self-assigned this Aug 3, 2021
@sourcegraph-bot sourcegraph-bot mentioned this issue Aug 3, 2021
Closed
71 tasks
@olafurpg
Copy link
Member Author

olafurpg commented Aug 3, 2021

Pending PR scalameta/metals#3018

@olafurpg
Copy link
Member Author

olafurpg commented Aug 4, 2021

Fixed in #280

@olafurpg olafurpg closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olafurpg olafurpg

Labels
dependency-indexing team/code-intelligence
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olafurpg