Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

definitions aren't output for templates #14

Closed
shrouxm opened this issue Sep 3, 2020 · 1 comment · Fixed by #28
Closed

definitions aren't output for templates #14

shrouxm opened this issue Sep 3, 2020 · 1 comment · Fixed by #28
Assignees
Labels
Milestone

Comments

@shrouxm
Copy link
Contributor

shrouxm commented Sep 3, 2020

For example, see https://sourcegraph.com/github.com/envoyproxy/envoy@670a4a6/-/blob/source/common/common/cleanup.h#L30:26

image

hover and references are all computed correctly, but no definition vertex is output.

https://sourcegraph.com/github.com/envoyproxy/envoy@670a4a6/-/blob/source/common/http/conn_manager_impl.cc#L127:31 is another good example, it even correctly infers the type of the auto variable, just the j2d is missing.

@aidaeology
Copy link

@gbrik What is the status of this issue, was this resolved with the 3.20 milestone or does it still need work? If it's resolved and longer a problem then please mark as closed and link the relevant PR. Otherwise please provide a status update on what the remaining work is to get it resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants