Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeGitPassHelper may supply password as username. #81

Open
dmitshur opened this issue Nov 17, 2015 · 0 comments
Open

makeGitPassHelper may supply password as username. #81

dmitshur opened this issue Nov 17, 2015 · 0 comments

Comments

@dmitshur
Copy link
Contributor

According to https://www.kernel.org/pub/software/scm/git/docs/gitcredentials.html:

Without any credential helpers defined, Git will try the following strategies to ask the user for usernames and passwords:

  1. If the GIT_ASKPASS environment variable is set, the program specified by the variable is invoked. A suitable prompt is provided to the program on the command line, and the user’s input is read from its standard output.

Emphasis mine.

If a username is not provided but a password is, it seems that using GIT_ASKPASS in the way that makeGitPassHelper does may arrange it to provide the password as username, and not provide any password, which would be desirable. We should prevent that from being possible.

/cc @neelance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant