Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rething short SHA handling with an eye on determenistic builds #116

Open
alerque opened this issue Nov 11, 2020 · 1 comment
Open

Rething short SHA handling with an eye on determenistic builds #116

alerque opened this issue Nov 11, 2020 · 1 comment

Comments

@alerque
Copy link
Member

alerque commented Nov 11, 2020

This has become a little bit of a sore point for me working on Fontship. I'm keeping an eye on reproducible builds for fonts as a long term goal and one thing that changes on me is how long the SHA is. This is a moving target because ⓐ upstream Git keeps changing their defaults and ⓑ global user configs can change this. My local system is generating 8 character short SHAs, remote CI is giving me 7.

I'd like to either be able to specify the SHA myself (I have the information already, I could pass it to font-v and save it the trouble of looking it up) or at least a way to specify it manually. Currently the only workaround I can think of is to fiddle with the local working directory's Git config before running font-v which kind of feels aggressive to me.

See #2 for discussion of current handling.

@alerque alerque changed the title Rething short SHA handling Rething short SHA handling with an eye on reproducablity Nov 11, 2020
@alerque alerque changed the title Rething short SHA handling with an eye on reproducablity Rething short SHA handling with an eye on determenistic builds Nov 11, 2020
@chrissimpkins
Copy link
Member

I'd like to either be able to specify the SHA myself

You can write the full version string programmatically with the font-v library (and without font-v automation of the git part of it).

https://github.com/source-foundry/font-v#set-entire-version-string-with-associated-metadata

Does that approach work?

I am open to changing the behavior here. We could use the full SHA string rather than an abbreviated short SHA or abandon this approach altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants