Fix h5pyf not found when flushing HDF5 output processor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonaldAJ
reviewed
Sep 29, 2017
There was a problem hiding this comment.
What happens if self.h5pyf is None? I think this is still a possible value.
In addition I found:https://hynek.me/articles/hasattr/ showing other potential risks.
|
Good point, thanks for the resource. I will update the PR accordingly |
|
I've updated the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case finalize is called on the file output processor, sometimes self.h5pyf is not found. In this case, using hasattr prevents Python throwing an error. For convenience, I've created a class method that can be called to flush and close the file handle