-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubernetes] Add support for k8s snap #3842
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/k8s.py
Outdated
f"{k8s_common}/var/lib/k8s-dqlite/info.yaml", | ||
f"{k8s_common}/var/lib/k8s-dqlite/cluster.yaml", | ||
f"{k8s_common}/var/lib/k8sd/state/truststore/k8s.yaml", | ||
f"{k8s_common}/var/lib/k8sd/state/database/info.yaml", | ||
f"{k8s_common}/var/lib/k8sd/state/database/cluster.yaml", | ||
f"{k8s_common}/var/lib/k8sd/state/daemon.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml
files cant contain any credentials worth to postproc
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have gone through these files maually twice :), and there isn't anything to obfuscate, except for /var/snap/k8s/common/var/lib/k8sd/state/truststore/k8s.yaml
, which I've already added in postproc()
I am now getting all of this verified by our k8s SMEs to ensure we got everything
Plugin looks fine. My only concern is around naming. We have |
Happy to change it to canonical_k8s if that would be better, or rather we just add the relevant tests and collect in the kubernetes plugin. I'm not precious in any way, as long as we collect the info, which is the main ethos here |
c75fee7
to
eaa59de
Compare
I've moved it now to the This also made me realise that we were collecting a folder, and obfuscating the said folder. So, actually needed less code adding. Maybe we can also move the |
Also, fix command for microk8s, and use variable Signed-off-by: Arif Ali <[email protected]>
eaa59de
to
7ef5cc7
Compare
Also, fix command for microk8s, and use variable
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines