Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[policies] Add AlmaLinux policy #3635

Merged
merged 1 commit into from
May 23, 2024

Conversation

eabdullin1
Copy link
Contributor

AlmaLinux OS is an Enterprise Linux distro, binary compatible with RHEL. This commit adds a AlmaLinux policy, which inherits the RedHatPolicy base.

Signed-off-by: Eduard Abdullin [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

AlmaLinux OS is an Enterprise Linux distro, binary compatible with RHEL.
This commit adds a AlmaLinux policy, which inherits the RedHatPolicy base.

Signed-off-by: Eduard Abdullin <[email protected]>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3635
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

pmoravec commented May 6, 2024

We can surely add a new policy, but the change as is will not alter sos behaviour at all.

Do you plan to add some child Plugin classes that will alter sos behaviour from RedHatPolicy?

@eabdullin1
Copy link
Contributor Author

We can surely add a new policy, but the change as is will not alter sos behaviour at all.

Do you plan to add some child Plugin classes that will alter sos behaviour from RedHatPolicy?

No. We don't plan to add child classes.

@TurboTurtle
Copy link
Member

TurboTurtle commented May 6, 2024

Does Alma plan on adding upload support to this policy at some point, so that users can specify for the --upload option and have the generated report automatically uploaded to a technical support case?

We typically like to see some kind of use-case behind policy additions; either plugins that have different behavior under different distros, upload support, a different package manager, some clustering mechanism for sos collect that is used with the new policy/distro, etc...

Given the size of the Alma community I'm good with picking this up, but I'd like to see how we can best work with each other.

@TurboTurtle
Copy link
Member

Drive by thought: we've long been wanting to directly test RHEL in our CI here but we run into the issue with cloud providers who by default charge per-instance for starting RHEL (which is doubly awkward given that RH is who sponsors our GCE costs). Does using Alma in CI make sense as a suitable stand in?

When I left RH there were some nebulous talks about how to get our GCE project setup for a "bring your own subscription" posture ("Cloud Access" for AWS, I forget what it's called for GCP) that would allow us to use official RHEL images without getting billed for the RHEL sub through GCE but I don't know if those continued at all?

@jcastill
Copy link
Member

jcastill commented May 8, 2024

One thing to bear in mind - Alma is picking up architectures and hardware that we are dropping/deprecating in RHEL, so we could end up with a situation where some tool or command does not exist in RHEL anymore but may be useful to capture for Alma. Would it make sense in this scenario to have an Alma policy? or would it be captured nonetheless?

About having RHEL images in GCP, if it's ok with you I'll do some research internally and see what's the current situation. If I cannot find a solution then we can check Alma images.

@arif-ali
Copy link
Member

arif-ali commented May 9, 2024

Another thought: we also have a Rocky policy already, and that could be an alternative as well and they also have cloud images on GCE so that's another route we could take for testing

@pmoravec
Copy link
Contributor

pmoravec commented May 9, 2024

Another thought: we also have a Rocky policy already, and that could be an alternative as well and they also have cloud images on GCE so that's another route we could take for testing

What would be the difference from using CentOS and Rocky images / what would be the benefit of testing sos on Rocky as well (or instead of CentOS?)? (I think we shall raise a separate discussion thread on :what images are worth to test sos on")

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The policy LGTM as is, however @eabdullin1 I'd be interested to know if the case upload support I mentioned is of any interest/value to Alma.

With regards to the testing conversation, I'll open a new GH discussion for it so that we don't derail this PR.

@eabdullin1
Copy link
Contributor Author

No at the moment

@TurboTurtle TurboTurtle merged commit 22cea2f into sosreport:main May 23, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants