Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branchLabelMapping 1:n mapping #445

Open
MstrDC opened this issue Oct 3, 2022 · 3 comments
Open

branchLabelMapping 1:n mapping #445

MstrDC opened this issue Oct 3, 2022 · 3 comments

Comments

@MstrDC
Copy link
Contributor

MstrDC commented Oct 3, 2022

Hello,

Playing around to get the backport github action working.
I am wondering if the following setup is supporter ( I guess currently not)
Am I correct in saying this? => "PR_Label": "Branch_Name"

"branchLabelMapping": {
        "master": "master",
        "2022.2": "release_2022.2",
        "2022.2": "release_2022.2AAA",
        "2022.2": "release_2022.2BBB"
    },

What I am seeing is that 1 label will be executed for only a single line in this list.
Any idea how I would get this working?
If not, would this be a feature you want in your tool?

Additionally I am wondering what will happen when there is a merge conflict.
Will it create the PR which people can checkout and fix? Or will it simple log an error and not create a PR?

@sorenlouv
Copy link
Owner

Hi there,

I think I can add support for this like:

"branchLabelMapping": {
        "master": "master",
        "2022.2": ["release_2022.2", "release_2022.2AAA", "release_2022.2BBB"]
},

WDYT?

@MstrDC
Copy link
Contributor Author

MstrDC commented Oct 4, 2022

@sqren ,
Looks good to me.
If for each label, it is merged to all listed branches and it doesnt break the current regex implementation?

@sorenlouv
Copy link
Owner

If for each label, it is merged to all listed branches and it doesnt break the current regex implementation?

Yes, that was my intention. Haven't had time to look into it yet but hope to do it soon-ish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants