Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If descent is zero, cufon returns empty string instead of zero for descent. #276

Open
tmccombs opened this issue Jun 8, 2015 · 1 comment

Comments

@tmccombs
Copy link

tmccombs commented Jun 8, 2015

If the descent of a font is 0, then cufon sets the descent to "" in the response JSON.

This is caused by a combination of initially setting the descent to "" in the $currentFace (line 119 of SVGFont.php) and comparing $actualValue to null with == instead of === on line 178 of SVGFont.php. In php 0 == null returns true.

@tmccombs
Copy link
Author

tmccombs commented Jun 8, 2015

I could make a pull request changing it to use === instead of == or 0 instead of "", but I don't know if either of those changes would break something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant