Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: .title command shows an error for links handled by another plugin #2055

Closed
dgw opened this issue Apr 25, 2021 · 0 comments · Fixed by #2282
Closed

url: .title command shows an error for links handled by another plugin #2055

dgw opened this issue Apr 25, 2021 · 0 comments · Fixed by #2282
Labels
Bug Things to squish; generally used for issues Medium Priority
Milestone

Comments

@dgw
Copy link
Member

dgw commented Apr 25, 2021

Description

Links handled by another plugin (for example links to GitHub issues, if the github plugin is installed) are skipped intentionally in the .title command, to avoid giving duplicate output. However, the error message code from #2029 can't tell the difference between a link that was intentionally skipped and a link for which a title couldn't be fetched.

Reproduction steps

  1. Command Sopel, .title http://some.link/that/another/plugin/handles
    • With core plugins only, a Reddit post is a good way to trigger this.
  2. url responds with an error: "Sorry, fetching that title failed. Make sure the site is working."
    AND the plugin that knows how to handle the link will also reply

Expected behavior

The url plugin should be silent in this case, unless multiple URLs are passed to .title and at least one of them isn't handled by another plugin.

Environment

  • Sopel .version: 7.1.0-dev
  • Sopel installed via: pip install -e
  • Python version: 3.8.5
  • Operating system: Ubuntu 18.04
  • Relevant plugins: url

Notes

Likely easiest to fix this in conjunction with #2054. I'm therefore marking this for 8.0 even though it would be nice to fix it in 7.1. (The target milestone is, as always, subject to change after discussion.)

@dgw dgw added the Bug Things to squish; generally used for issues label Apr 25, 2021
@dgw dgw added this to the 8.0.0 milestone Apr 25, 2021
@dgw dgw closed this as completed in #2282 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants