Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages were removed from .title command #1946

Closed
dgw opened this issue Sep 29, 2020 · 0 comments · Fixed by #2029
Closed

Error messages were removed from .title command #1946

dgw opened this issue Sep 29, 2020 · 0 comments · Fixed by #2029
Assignees
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Milestone

Comments

@dgw
Copy link
Member

dgw commented Sep 29, 2020

In #1510, the error feedback Sopel used to output if it couldn't find a title for one or more URL given to the .title command got removed. This is kind of regression-y, and was shipped already in 7.0.x before someone mentioned it. Here's how it looked:

sopel/sopel/modules/url.py

Lines 132 to 137 in 806f296

# Nice to have different failure messages for one-and-only requested URL
# failed vs. one-of-many failed.
if len(urls) == 1 and not results:
bot.reply('Sorry, fetching that title failed. Make sure the site is working.')
elif len(urls) > len(results):
bot.reply('I couldn\'t get all of the titles, but I fetched what I could!')
Might not be practical to do exactly the same thing now due to use of generators, but something similar would be enough.

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Sep 29, 2020
@dgw dgw added this to the 7.1.0 milestone Sep 29, 2020
@dgw dgw self-assigned this Feb 25, 2021
@dgw dgw closed this as completed in #2029 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant