Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: .set command can't handle spaces #1384

Closed
dgw opened this issue Sep 23, 2018 · 0 comments · Fixed by #1385
Closed

admin: .set command can't handle spaces #1384

dgw opened this issue Sep 23, 2018 · 0 comments · Fixed by #1385
Assignees
Labels
Bug Things to squish; generally used for issues Medium Priority
Milestone

Comments

@dgw
Copy link
Member

dgw commented Sep 23, 2018

I think I once discovered this a long, long time ago and forgot to document it. I vaguely remember hitting this problem way back when I first started using Sopel (at the time, Willie)… But here we are. I hit it again, and this time it's getting an issue so it can be fixed!

When PMing Sopel .set section.key spam eggs sausage and spam, the value in section.key of the config will become simply spam. Because admin.py uses trigger.group(4) as the value, it ignores anything after the first whitespace.

The .set command probably isn't used a whole lot, but it should still work as expected. As-is, it's useless for updating things like core.default_time_format, which almost always contain spaces.

@dgw dgw added Bug Things to squish; generally used for issues Medium Priority labels Sep 23, 2018
@dgw dgw added this to the 6.6.0 milestone Sep 23, 2018
@dgw dgw self-assigned this Sep 23, 2018
@dgw dgw closed this as completed in #1385 Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant