Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Stream Notifier #101

Open
kpirnie opened this issue Aug 24, 2024 · 6 comments
Open

Failed Stream Notifier #101

kpirnie opened this issue Aug 24, 2024 · 6 comments
Labels
enhancement New feature or request low priority This will be worked on but with low priority

Comments

@kpirnie
Copy link
Contributor

kpirnie commented Aug 24, 2024

Any way a "This Stream Has Failed" image or looping vid could be added in for when a stream fails?
@kpirnie kpirnie added the enhancement New feature or request label Aug 24, 2024
@kpirnie kpirnie changed the title Failed Stream Failed Stream Notifier Aug 24, 2024
@sonroyaalmerol
Copy link
Owner

This is something I'm not 100% sure if it's feasible without using ffmpeg and I'd like to avoid using it just for this feature (pretty overkill).

@sonroyaalmerol sonroyaalmerol added the low priority This will be worked on but with low priority label Aug 24, 2024
@kpirnie
Copy link
Contributor Author

kpirnie commented Aug 24, 2024

This is something I'm not 100% sure if it's feasible without using ffmpeg and I'd like to avoid using it just for this feature (pretty overkill).

:)
I would just inject a public URL to a tiny looping video ;)

@kpirnie kpirnie closed this as completed Aug 24, 2024
@kpirnie kpirnie reopened this Aug 24, 2024
@sonroyaalmerol
Copy link
Owner

That would not guarantee that the tiny looping video will have the same encoding as the previously running stream which will confuse the client running the stream. The tiny looping video should match the mime-type initially sent via the HTTP header which is derived from the original source stream that "failed".

However, I've never really tried it as I figured it would be a pain if my assumptions above are correct.

@kp-emagine
Copy link

That would not guarantee that the tiny looping video will have the same encoding as the previously running stream which will confuse the client running the stream. The tiny looping video should match the mime-type initially sent via the HTTP header which is derived from the original source stream that "failed".

However, I've never really tried it as I figured it would be a pain if my assumptions above are correct.

Maybe I'll give it a shot in my fork ;) I want to learn Go anyways, it'd be a good excercise. Same with integrating ffmpeg... for some clients, i can see that being beneficial, but it would make the container's pretty big if I do it the way I'm thinking lololol

@sonroyaalmerol
Copy link
Owner

Sure! Feel free to create a PR for this if you're able to figure out an easy way to do it. I'm not planning on doing this anytime soon

@kpirnie
Copy link
Contributor Author

kpirnie commented Aug 26, 2024

:)
Got a couple cool mini-vids through AI now...

https://n1u5.c15.e2-5.dev/kp-cdn/channel-offline-1.mp4
https://n1u5.c15.e2-5.dev/kp-cdn/channel-offline-2.mp4

I really like that first one, other than AI spelt channel wrong in it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority This will be worked on but with low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sonroyaalmerol @kp-emagine @kpirnie