-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModOrganizer 2: Add option to Select Custom Installer Executable #935
Conversation
Commandline usage added. |
Helpscreen updated. |
Langfiles updated. |
The main remaining work on this PR now is testing, and then writing up the wiki updates. Once this is confirmed to be working, I'll update the wiki. It may be a while before I can test, so I'd appreciate any community testing. |
Should also more on the wiki that this option could be particularly useful if using two ModOrganizer compatdatas and that you could swap between versions this way. |
May have to change the UI element type, think I got it wrong... |
Fixed exe file picker element type and resolved conflicts. |
Hoping to test and merge this over the weekend. |
Okay, did some fixups and testing here. It works as expected. Tested this PR with using ModOrganizer 2.5.0 and ModOrganizer 2.4.2 (2.5.0 does not install but I used it as a test executable that was not 2.4.4).
I'll do a quick ShellCheck on this and make any required changes, then update the wiki and merge this. Finally, this PR is out of development hell! |
No changes required for ShellCheck. Will do a final glance over the code, bump the version and merge once the wiki is updated. |
2a82bcd
to
8aaf71c
Compare
Code looks good, ShellCheck is green, wiki is updated (Commandline Usage updated, Global Menu configuration section added), version is bumped. This is ready to merge! |
Overview
This PR adds an option on the Global Menu under ModOrganizer 2 options, to specify a custom installer executable. This is useful if there is a custom/unofficial build that a user wants to install, such as a build that was rumoured to be floating around on a Discord server with Starfield support. A user could also build MO2 from source and this option would allow them to install it.
This option is gated behind a checkbox on the Global Menu, so that it is not accidentally enabled. Also, if the file does not exist, we will fall back to downloading MO2 from GitHub.
Right now, this change is entirely untested, as I am using MO2 on my PC right now, and I don't mod on my Steam Deck. I'll need to dig out my laptop+charge/update etc, so it may be a while before I can test.
It would be great if someone could test this and see if it works!
Future Work
I'm hoping in future to apply a very similar change to Vortex. I had originally wanted to do this for Vortex (#810), but went with MO2 first because I actually like and use MO2, and it was a slightly more straightforward change compared to Vortex (as with Vortex we would have to work into the logic to ignore the version/channel etc).
TODO:
install
command (will be a delicate operation no doubt