Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(steamdeck): custom variable to detect #1055

Closed
wants to merge 1 commit into from
Closed

feat(steamdeck): custom variable to detect #1055

wants to merge 1 commit into from

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented Mar 15, 2024

ref #859

Right now just the variable as it isn't for me understand when needed to be used.

@sonic2kk
Copy link
Owner

sonic2kk commented Mar 15, 2024

@Mte90
Copy link
Contributor Author

Mte90 commented Mar 18, 2024

No it is the same thing but the ticket about steam deck mentioned that it was needed to check if the device was steam deck. Check all the code it isn't easy so I didn't noticed.

@Mte90 Mte90 closed this Mar 18, 2024
@sonic2kk
Copy link
Owner

I don't see this being mentioned as something that needs to be implemented. Did I make a mistake somewhere? We already use this variable in a lot of places to do conditional Steam Deck things, like disable various options that don't make sense in Game Mode (such as GameScope, MangoHud, GameMode, etc) and when performing the Steam Deck installation.

This wasn't implemented as part of #859 either, it has been around since Steam Deck skeleton code was added (commit from probably around this time 2 years ago, so I couldn't find it 😅), so if I gave the impression it has to be added, very sorry and I'll happily correct it!

@Mte90
Copy link
Contributor Author

Mte90 commented Mar 18, 2024

So #859 mention to do some stuff about Steam deck but doesn't mention that there is a variable for that so I thought that a detection was needed.

Anyway it isn't a problem, I have VM now for steam deck :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants