-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Vortex downgrade #809
Comments
Thanks for the feature request!
Fresh installs of Vortex 1.8.0 and above work for me on Arch Linux with GE-Proton8-2 using STL-git. This has also been confirmed to work on Linux Desktop by another user, the outlier appears to be SteamOS (though #807 may resolve it, pending testing). If you're still having issues you could try STL from latest master, as it changes a little bit of the install process (mainly removes I did consider the possibility of giving users the option to install older Vortex versions (mentioned in #802 (comment) 😉), particularly given that STL now has support for disabling Vortex auto-updates. The issue is that when specifying an older Vortex version, automatic updates would have to be disabled, otherwise Vortex has a chance of automatically updating. I'm not sure if this is a good idea or not, given that older Vortex versions will eventually have a cut-off according to Vortex (it shows a warning when you disable automatic updates), and a user might install an older version and have it also not work. However, a user can simply have enough sense to know that they should disable automatic updates before specifying a custom version. From a user perspective, I like both of the commands you have listed, and I would like to add both of them. On the Global Menu I would like to add both as well but it's probably okay to just add a checkbox+dropdown for "Custom Vortex Version". A tooltip for them would probably also outline that using an older Vortex version should go hand-in-hand with disabling automatic updates to prevent Vortex from updating itself. A custom Vortex installer would still be supported from the commandline, I am hesitant to add it to the UI because I am not sure what should be "prioritised." if a user enables both, I would be inclined to say the custom installer would take priority, but not sure. The real solution here is for Vortex to be more careful about breaking things downstream, but I am not against the principle of specifying a version :-) |
Taking an initial look at what might be required to implement this. A lot of the logic is already present, f.e. we already have code to get the last N GitHub tags for a project since #649, and we already have code to fetch GitHub releases. I think we'd just need to adapt the latest code logic to allow downloading based on a given tag. The latest version logic currently looks for the latest tag when it comes to pre-releases, and then builds a URL for the download using the latest tag, so it shouldn't be too hard to adapt some logic to take a given tag. There have been a number of improvements to Vortex support in STL-git, so even though I don't use or much like Vortex, this change wouldn't be too out-of-place. My main concern is ensuring specified versions won't get overwritten, but I am hesitant to enable the disable auto-update option when a custom version is provided. Doing that kind of thing is a bit more hands-on than I'd like STL to be. |
#810 is up which implements the version selection part. Example usage would be If a version of Vortex that you are installing (either an older one, newer one, or unofficial one) requires various dependencies that STL no longer provides automatically, you'll need to specify a custom prefix to install Vortex into from the Global Menu which has the required dependencies; ex: if Vortex 1.7.0 requires The PR does not implement selecting a custom executable, I will work on that in a separate PR. If you'd like to test this branch, you can clone the repo, checkout the The PR only updates the English langfile, if you're using a different language let me know and I can update that langfile on the PR. I only update the English langfile during development in case some wordings change. |
Hey @sonic2kk , |
Thank you for testing! Just a shot in the dark: Perhaps you need to update Winetricks ? Could you also clarify where exactly you're seeing this message? Is it in the terminal, or the window that appears during Vortex installation? I think it's the latter but I'd just like to confirm. The changes in the branch should only touch the downloading logic, as this fetches and downloads the executable based on a given version, and then tells STL to use this executable for the installation process (which already happens, basically this PR just sets the version and the install etc logic is untouched). It could be that this issue comes from using STL-git where we now use Winetricks to install dotnet6, and sometimes Winetricks needs to be bleeding edge for newer Proton versions. You can check the STL log and do a search for Feel free to try again on master and see if you get the same issue. I'll investigate myself later on when I have some time too :-) |
Just tested this with Vortex 1.8.0 and it installed for me, using Looking up the message a little bit, it seems this comes from the Steam client: https://bbs.archlinux.org/viewtopic.php?id=285889 Did you have Steam opened while testing? Vortex, for some reason, will open Steam during installation (there is probably a command STL runs somewhere that opens Steam, which I never noticed until the other day when Steam happened to crash without me realising it). It is possible that opening Steam and trying again may fix it, if Winetricks does not. The message may be a red herring as it could just be output from the Steam client being piped to the StatusWindow. |
Yeah so I just did a winetricks update and now it all works correctly. Install went through with some error messages (windows version not compatible and rundll32 cannot run the application) but most probably something wrong with my wine configuration. Steam automatically opens for me too during vortex install/start. Steam automatically opens for me too during vortex install/start. Thanks for the quick implementation, this will be very useful in the future IMO. |
Those issues are strange but it is probably more to do with Wine (either your config or in general) than something STL is doing. There was one other report a while ago about the Wine version, but I couldn't reproduce it. As for the rundll32 error, I believe I have seen a similar issue when switching between Proton versions but that was mostly to do with dotnet48 (e.g. installing dotnet48 with Proton Version X and running something in that prefix, then running the same thing again in that prefix with Proton Version Y). What matters though is that Vortex is working :-) Info dialogs like that are a bit annoying speaking from a user perspective but I can't reproduce them at the moment. If you (or anyone reading this from the future) knows how to resolve the problems I'd be happy to try and patch it though! I'd just like to confirm that the standard Vortex behaviour still works for you, i.e.
No problem at all, thank you for testing and helping out! Based on your testing I'll probably also update the changelog courtesy note to remind users to update Winetricks manually, it's an easy step to miss in all fairness. I also think this feature will be useful, with the caveat that installing older versions may not have all the necessary setup steps. It would be infeasible to account for/check for different Vortex versions and only install XYZ dependencies for a given version. Ex: However, STL gives users the tools to point Vortex to a different prefix which they can configure themselves. I may look into an option to run Winetricks in Vortex's prefix at some point specifically for cases like this to make the tinkering slightly more straightforward, though I'd want to allow opening the Winetricks GUI as well as passing arguments from the commandline, so I'd need to figure that out first. I'll update the help page for Vortex to document this new functionality, as well as updating the langfiles. I'll then do one final pass at testing, and then merge. Should hopefully be merged in tonight. Once it is, I'll post a note here and close this issue. Thanks again! |
Oh, I totally forgot about the part of this feature request for a custom Vortex executable. I'll probably add that in a separate PR :-) |
The option to use a custom Vortex version based on a tag has been added with fb28b0c, I'll close this issue now :-) Thanks! |
System Information
Feature Description
Give the possibility to install an older version of Vortex as newer install tend to break. This can be manually downloaded and then installed through the STL terminal command specifying the path to the install file e.g.:
Or if possible just by specifying version number, STL should install the requested version such as:
Please correct me if this is already possible. Currently it is locking me out of using Vortex since the latest install fails with any provide proton version. Older Vortex installed without problem.
The text was updated successfully, but these errors were encountered: