Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github download changed #597

Closed
frostworx opened this issue Sep 23, 2022 · 2 comments
Closed

github download changed #597

frostworx opened this issue Sep 23, 2022 · 2 comments

Comments

@frostworx
Copy link
Collaborator

The github internal download urls changed, so multiple download parts in steamtinkerlaunch need to be rewritten.
When done steamtinkerlaunch will (likely) require jq as hard dependency (until now it was optional) because the github api will be used.

@sonic2kk
Copy link
Owner

The GitHub API does have a rate limit per user, but I believe it's fairly high. I think even if a user downloaded every available tool with STL they still wouldn't hit it. You can avoid this by passing a GitHub access token to the API call in the header ('Authorization').

Maybe as a "precaution" there could be an option to pass an access token to SteamTinkerLaunch? Either via command line and/or in the Global menu 😃

@frostworx
Copy link
Collaborator Author

frostworx commented Sep 23, 2022

good hint, thanks! didn't know that.
yeah using an optional token probably makes sense. Need to look into it.
seems like
https://github.com/settings/tokens
is the url the user has to visit for getting a token

edit:
the wget syntax from https://superuser.com/a/810160
is probably still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants