[202205] Fix issue: out of range sflow polling interval is accepted and stored in config_db (#2847) #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in config_db (sonic-net#2847) Fixed issue: out of range sflow polling interval is accepted and stored in config_db. Reproduce step: ``` 1. Enable sflow feature: config feature state sflow enabled 2. Enable sflow itself: config sflow enable 3. Configure out of range polling interval: config sflow polling-interval 1. Error message is shown as expected 4. Save config: config save -y 5. Check "SFLOW" section inside config_db ``` As the interval is invalid, the expected behavior is that the interval is not saved to redis. But we see the invalid value was written to redis. Change `click.echo` to `ctx.fail` 1. Manual test 2. Add a check in existing unit test case to cover the change
|
Failed due to unable to download swss-common package, which isn't relevant to the PR. |
keboliu
approved these changes
Jan 15, 2024
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipeline run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 @yxieca could you please help to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to backport #2847 to 202205
Fixed issue: out of range sflow polling interval is accepted and stored in config_db.
Reproduce step:
As the interval is invalid, the expected behavior is that the interval is not saved to redis. But we see the invalid value was written to redis.
Change
click.echotoctx.failWhat I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)