[202012] [generate_dump] allow to extend dump with plugin scripts

[noaOrMlnx]

Signed-off-by: Noa Or [email protected]

What I did

Added support for tech support extension scripts,
by cherry-picking of #1335 to branch 202012

The purpose is to have dumps of extensions in SONiC techsupport, even without App Extension infrastructure.
The new application will write a file that contains the dump command into /usr/bin/debug-dump folder, and it will appear in the output of show techsupport command.

How I did it

It looks at /usr/bin/debug-dump for scripts, if it finds one it will execute them and save the output to dump/ folder.

How to verify it

Write a simple scripts that outputs something and place it under /usr/bin/debug-dump/

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

[liat-grozovik]

@qiluo-msft could you please help to review?

[noaOrMlnx]

@qiluo-msft
A kind reminder

[stephenxs]

@noaOrMlnx With this PR merged, there are the following errors:

2021-12-15T21:00:30.1409842Z         # Raise exception if host(s) unreachable
2021-12-15T21:00:30.1410931Z         # FIXME - if multiple hosts were involved, should an exception be raised?
2021-12-15T21:00:30.1411322Z         if cb.unreachable:
2021-12-15T21:00:30.1411888Z >           raise AnsibleConnectionFailure("Host unreachable", dark=cb.unreachable, contacted=cb.contacted)
2021-12-15T21:00:30.1412379Z E           AnsibleConnectionFailure: Host unreachable

Check kvm t0 and kvm t1-lag for details.

[liat-grozovik]

If this is constantly raised and we are sure this is due to specific PR I suggest to revert it @noaOrMlnx<https://github.com/noaOrMlnx> please note and work to have the original PR back Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Stephen Sun ***@***.***> Sent: Friday, December 17, 2021 6:25:50 AM To: Azure/sonic-utilities ***@***.***> Cc: Liat Grozovik ***@***.***>; Comment ***@***.***> Subject: Re: [Azure/sonic-utilities] [202012] [generate_dump] allow to extend dump with plugin scripts (PR #1945) @noaOrMlnx<https://github.com/noaOrMlnx> With this PR merged, there are the following errors: 2021-12-15T21:00:30.1409842Z # Raise exception if host(s) unreachable 2021-12-15T21:00:30.1410931Z # FIXME - if multiple hosts were involved, should an exception be raised? 2021-12-15T21:00:30.1411322Z if cb.unreachable: 2021-12-15T21:00:30.1411888Z > raise AnsibleConnectionFailure("Host unreachable", dark=cb.unreachable, contacted=cb.contacted) 2021-12-15T21:00:30.1412379Z E AnsibleConnectionFailure: Host unreachable Check kvm t0<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdev.azure.com%2Fmssonic%2Fbe1b070f-be15-4154-aade-b1d3bfb17054%2F_apis%2Fbuild%2Fbuilds%2F59357%2Flogs%2F70&data=04%7C01%7Cliatg%40nvidia.com%7C3e61f29d0d0843f1b13908d9c1154e74%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637753119521521888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=LYpuS%2FzfR0zFA5jmSgiR7v0gpJ0njWRF2R9fMobJNoA%3D&reserved=0> and kvm t1-lag<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdev.azure.com%2Fmssonic%2Fbe1b070f-be15-4154-aade-b1d3bfb17054%2F_apis%2Fbuild%2Fbuilds%2F59357%2Flogs%2F79&data=04%7C01%7Cliatg%40nvidia.com%7C3e61f29d0d0843f1b13908d9c1154e74%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637753119521521888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Hdrgd7SmMe6e4QmE%2FJ9i9xAcVrfWlhL04zR4btsq8yQ%3D&reserved=0> for details. — Reply to this email directly, view it on GitHub<#1945 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABAZR5IKTVHHCJRWCMLLURK3U5ANCNFSM5IVOEDHA>. Triage notifications on the go with GitHub Mobile for iOS<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cliatg%40nvidia.com%7C3e61f29d0d0843f1b13908d9c1154e74%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637753119521521888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ATZIorhyVIaZyh7AYCRjuCY7IuPCcRJgqmK5Ig0QyRg%3D&reserved=0> or Android<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cliatg%40nvidia.com%7C3e61f29d0d0843f1b13908d9c1154e74%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637753119521521888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NheQ2v0uAXRUyPV8qp0Q5O0YaxGfhoBfBX5oOMbNY2s%3D&reserved=0>. You are receiving this because you commented.Message ID: ***@***.***>

[noaOrMlnx]

@stephenxs
Hi,
the new cherry-pick goes into debug-dump folder and execute commands from the files we have in there.
since we don't have plugin folder in kvm, I think this change cannot be caused from my change.

please retrigger and update, thanks!

[stephenxs]

@stephenxs Hi, the new cherry-pick goes into debug-dump folder and execute commands from the files we have in there. since we don't have plugin folder in kvm, I think this change cannot be caused from my change.

please retrigger and update, thanks!

A draft PR has been created for dry run: sonic-net/sonic-buildimage#9617