-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[debug dump util] Techsupport addition #1669
[debug dump util] Techsupport addition #1669
Conversation
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
…o techsupport_addition
Request for 202106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Vivek Reddy Karri <[email protected]>
Changes in latest commit: made the collection of debug dump configurable in techsupport and is not enabled by default |
@SuvarnaMeenakshi can you approve and merge? |
Signed-off-by: Vivek Reddy Karri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@SuvarnaMeenakshi, Can you sign-off this pr? |
What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in #1666 #1667 #1668 #1669 #1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Signed-off-by: Vivek Reddy Karri [email protected]
DEBUG DUMP UTIL PR SEQ: 4
NOTE: PLEASE MERGE #1668 BEFORE MERGING THIS
What I did
HLD for Dump Utility: HLD.
For More info on Tech Support Addition: TechSupport
How I did it
Module Names are retrieved by parsing the output of dump state --show command.
Eg:
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)