"show int status" command fails on multi-asic/chassis devices.

[judyjoseph]

Description

The sanity was failing for chassis & multi-asic devices with the following error in pre-sanity

E                   "msg": "Command failed rc = 1, out = Invalid port 'Ethernet-IB0'\n, err = Traceback (most recent call last):\n  File \"/usr/local/bin/intfutil\", line 838, in <module>\n    main()\n  File \"/usr/local/bin/intfutil\", line 821, in main\n    interface_stat.display_intf_status()\n  File \"/usr/local/bin/intfutil\", line 448, in display_intf_status\n    self.get_intf_status()\n  File \"/usr/local/lib/python3.9/dist-packages/utilities_common/multi_asic.py\", line 151, in wrapped_run_on_all_asics\n    func(self,  *args, **kwargs)\n  File \"/usr/local/bin/intfutil\", line 535, in get_intf_status\n    self.table += self.generate_intf_status()\n  File \"/usr/local/bin/intfutil\", line 479, in generate_intf_status\n    port_oper_speed_get(self.db, key),\n  File \"/usr/local/bin/intfutil\", line 204, in port_oper_speed_get\n    optics_type = port_optics_get(db, intf_name, PORT_OPTICS_TYPE)\n  File \"/usr/local/bin/intfutil\", line 224, in port_optics_get\n    if is_rj45_port(intf_name):\n  File \"/usr/local/lib/python3.9/dist-packages/utilities_common/platform_sfputil_helper.py\", line 134, in is_rj45_port\n    physical_port = logical_port_name_to_physical_port_list(port_name)[0]\nTypeError: 'NoneType' object is not subscriptable\n"

The "show int status" command also fails

admin@str2--lc1-1:~$ show int status
Traceback (most recent call last):
  File "/usr/local/bin/intfutil", line 838, in <module>
    main()
  File "/usr/local/bin/intfutil", line 821, in main
    interface_stat.display_intf_status()
  File "/usr/local/bin/intfutil", line 448, in display_intf_status
    self.get_intf_status()
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/multi_asic.py", line 151, in wrapped_run_on_all_asics
    func(self,  *args, **kwargs)
  File "/usr/local/bin/intfutil", line 535, in get_intf_status
    self.table += self.generate_intf_status()
  File "/usr/local/bin/intfutil", line 479, in generate_intf_status
    port_oper_speed_get(self.db, key),
  File "/usr/local/bin/intfutil", line 204, in port_oper_speed_get
    optics_type = port_optics_get(db, intf_name, PORT_OPTICS_TYPE)
  File "/usr/local/bin/intfutil", line 224, in port_optics_get
    if is_rj45_port(intf_name):
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/platform_sfputil_helper.py", line 139, in is_rj45_port
    physical_port = logical_port_name_to_physical_port_list(port_name)[0]
TypeError: 'NoneType' object is not subscriptable
Invalid port 'Ethernet-IB0'

This was added via #2249, we need to handle special interfaces like Inband/Recirc/Backplane etc in the API is_rj45_port().

Options to fix

1. Skip for those types of interfaces (REF : https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-py-common/sonic_py_common/interface.py#L16)
2. Validation check before accessing logical_port_name_to_physical_port_list(port_name)[0] https://github.com/sonic-net/sonic-utilities/blob/master/utilities_common/platform_sfputil_helper.py#L134

Steps to reproduce the issue

1. Issue a show int status

Describe the results you received

Error in the is_rj45_port API.

Describe the results you expected

show interface status o/p

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

Latest 202205

(paste your output here)

[judyjoseph]

@stephenxs, could you take a look at this issue, we need to handle specially for certain interfaces ?

[stephenxs]

@stephenxs, could you take a look at this issue, we need to handle specially for certain interfaces ?

checking.

[stephenxs]

2. logical_port_name_to_physical_port_list

Vote for 2. We can catch the exception and treat it as non-RJ45 port if there is an exception

[stephenxs]

Fixed by #2313

[judyjoseph]

@stephenxs there is a minor issue to fix in PR #2313, following error

File "/usr/local/bin/intfutil", line 204, in port_oper_speed_get
optics_type = port_optics_get(db, intf_name, PORT_OPTICS_TYPE)
File "/usr/local/bin/intfutil", line 224, in port_optics_get
if is_rj45_port(intf_name):
File "/usr/local/lib/python3.9/dist-packages/utilities_common/platform_sfputil_helper.py", line 142, in is_rj45_port
return port_type == platform_sfp_base.SFP_PORT_TYPE_BIT_RJ45
UnboundLocalError: local variable 'port_type' referenced before assignment
Invalid port 'Ethernet-Rec0'

Could you add a quick fix, I think we can remove the "if physical_port:" check

[stephenxs]

@stephenxs there is a minor issue to fix in PR #2313, following error

File "/usr/local/bin/intfutil", line 204, in port_oper_speed_get optics_type = port_optics_get(db, intf_name, PORT_OPTICS_TYPE) File "/usr/local/bin/intfutil", line 224, in port_optics_get if is_rj45_port(intf_name): File "/usr/local/lib/python3.9/dist-packages/utilities_common/platform_sfputil_helper.py", line 142, in is_rj45_port return port_type == platform_sfp_base.SFP_PORT_TYPE_BIT_RJ45 UnboundLocalError: local variable 'port_type' referenced before assignment Invalid port 'Ethernet-Rec0'

Could you add a quick fix, I think we can remove the "if physical_port:" check

Maybe initialize port_type before try block

[stephenxs]

@stephenxs there is a minor issue to fix in PR #2313, following error
File "/usr/local/bin/intfutil", line 204, in port_oper_speed_get optics_type = port_optics_get(db, intf_name, PORT_OPTICS_TYPE) File "/usr/local/bin/intfutil", line 224, in port_optics_get if is_rj45_port(intf_name): File "/usr/local/lib/python3.9/dist-packages/utilities_common/platform_sfputil_helper.py", line 142, in is_rj45_port return port_type == platform_sfp_base.SFP_PORT_TYPE_BIT_RJ45 UnboundLocalError: local variable 'port_type' referenced before assignment Invalid port 'Ethernet-Rec0'
Could you add a quick fix, I think we can remove the "if physical_port:" check

Maybe initialize port_type before try block

#2323